Perl::...appings(3pm)

🌸 NAME 🌸

Perl::Critic::Policy::BuiltinFunctions::ProhibitComplexMappings β€” map blocks should have a single statement. This page is the Perl::...appings(3pm) entry in User Contributed Perl Documentation, and bestie, it is here to keep your map blocks from trying to do too much πŸ’….

🫢 AFFILIATION 🫢

This Policy is part of the core Perl::Critic distribution. Slay.

✨ DESCRIPTION ✨

Okay so real talk: the map function can be confusing to novices in the best of circumstances. Mappings with multiple statements are even worse. They’re also a maintainer’s nightmare because any added complexity decreases readability precipitously 😭. Why? Because map is traditionally a one-liner converting one array to another. Trying to cram lots of functionality into a one-liner is a bad idea in general, fr fr.

The best solutions to a complex mapping are:

  1. write a subroutine that performs the manipulation and call that from map;
  2. rewrite the map as a for loop.

😭 CAVEATS 😭

This policy currently misses some compound statements inside of the map. For example, the following code incorrectly does not trigger a violation:

map { do { foo(); bar() } } @list
Not me pointing out the gap so you know exactly what’s up πŸ™ˆ.

πŸŽ€ CONFIGURATION πŸŽ€

By default this policy flags any mappings with more than one statement. While we do not recommend it, you can increase this limit as follows in a .perlcriticrc file:

[BuiltinFunctions::ProhibitComplexMappings]
max_statements = 2

🌸 AUTHOR 🌸

Chris Dolan <cdolan@cpan.org>

πŸ‘‘ CREDITS πŸ‘‘

Initial development of this policy was supported by a grant from the Perl Foundation. Iconic behavior honestly 🫢.

Copyright (c) 2007-2011 Chris Dolan.

This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself.


Bye bestie πŸ’– β€” this page came from perl v5.42.0, dated 2024-10-23. Periodt ✨.

πŸ“¦ where this page comes from